feat(deps): Bump @prisma/instrumentation from 5.19.1 to 6.0.1 #14624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
It's also Node 18+ Tests seem to pass, but we prob need an extended discussion about this. |
|
I'd say let's stay on v5 and then bump this on the v9 branch, where we'll also be 18+ and on TS 5.0 (which is not exactly theirs but should realistically be fine - hopefully). Especially as this is still opt-in it should be OK on v9 I believe? |
mydea
requested changes
Dec 10, 2024
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/prisma/instrumentation-6.0.1
branch
2 times, most recently
from
fde4c6a to
8d15c1e
Compare
Yeah seems like a good plan to evaluate this on v9! |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/prisma/instrumentation-6.0.1
branch
2 times, most recently
from
83649da to
3b6753a
Compare
2 tasks
|
FYI, I've made a PR to update Please check out #14753! The release notes for 5.22.0 explicitly say:
So it sounds like it would be good to get |
mydea
pushed a commit
that referenced
this pull request
Dec 17, 2024
…14753) Bump [@prisma/instrumentation](https://github.com/prisma/prisma/tree/HEAD/packages/instrumentation) from 5.19.1 to 5.22.0. See https://github.com/prisma/prisma/releases/tag/5.22.0 for release notes. This is to take advantage of the following change in 5.22.0: > In our ongoing effort to stabilize the tracing Preview feature, we’ve made our spans compliant with OpenTelemetry Semantic Conventions for Database Client Calls. **This should lead to better compatibility with tools such as DataDog and Sentry** [emphasis added by me]. There's also this change in [5.21.0](https://github.com/prisma/prisma/releases/tag/5.21.0): > The `tracing` Preview feature now has full support for MongoDB with previously missing functionality now implemented. This is a part of the ongoing effort to stabilize this Preview feature and release it in General Availability. The @dependabot PR for `@prisma/instrumentation` updates this to 6.0.0, which unfortunately drops Node.JS v18 support, so it isn't suitable for Sentry v8: #14624 --- Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ ] If you've added code that should be tested, please add tests. - [ ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`). - I'm getting a bunch of errors when I run `yarn lint && yarn test`, but I think they seem to be unrelated to this PR, since this is just a simple dependency update.
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/prisma/instrumentation-6.0.1
branch
from
3b6753a to
5bb2145
Compare
Bumps [@prisma/instrumentation](https://github.com/prisma/prisma/tree/HEAD/packages/instrumentation) from 5.19.1 to 6.0.1. - [Release notes](https://github.com/prisma/prisma/releases) - [Commits](https://github.com/prisma/prisma/commits/6.0.1/packages/instrumentation) --- updated-dependencies: - dependency-name: "@prisma/instrumentation" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/prisma/instrumentation-6.0.1
branch
from
5bb2145 to
30729b8
Compare
mydea
added a commit
that referenced
this pull request
Dec 17, 2024
#14755) Backport of #14753: Bump [@prisma/instrumentation](https://github.com/prisma/prisma/tree/HEAD/packages/instrumentation) from 5.19.1 to 5.22.0. See https://github.com/prisma/prisma/releases/tag/5.22.0 for release notes. This is to take advantage of the following change in 5.22.0: > In our ongoing effort to stabilize the tracing Preview feature, we’ve made our spans compliant with OpenTelemetry Semantic Conventions for Database Client Calls. **This should lead to better compatibility with tools such as DataDog and Sentry** [emphasis added by me]. There's also this change in [5.21.0](https://github.com/prisma/prisma/releases/tag/5.21.0): > The `tracing` Preview feature now has full support for MongoDB with previously missing functionality now implemented. This is a part of the ongoing effort to stabilize this Preview feature and release it in General Availability. The @dependabot PR for `@prisma/instrumentation` updates this to 6.0.0, which unfortunately drops Node.JS v18 support, so it isn't suitable for Sentry v8: #14624
This was referenced Dec 18, 2024
|
Superseded by #14801. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/prisma/instrumentation-6.0.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @prisma/instrumentation from 5.19.1 to 6.0.1.
Release notes
Sourced from
@prisma/instrumentation's releases.... (truncated)
Commits
4a827d4chore(deps): update jest (#25682)7496049chore(deps): update engines to 5.22.0-12.8263a1f2b3deb0a72687cad83ceb981a2562...2d1884achore(deps): Allow@opentelemetry/instrumentationv0.53.0 (#25160)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)