Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node)!: Collect request sessions via HTTP instrumentation #14658

Draft
wants to merge 30 commits into
base: develop
Choose a base branch
from

Conversation

lforst
Copy link
Member

@lforst lforst commented Dec 11, 2024

No description provided.

lforst and others added 8 commits December 11, 2024 17:48
With this PR, the default value for the `spans` option in the
`httpIntegration` is changed to `false`, if `skipOpenTelemetrySetup:
true` is configured. This is what you'd expect as a user, you do not
want Sentry to register any OTEL instrumentation and emit any spans in
this scenario.

Closes #14675
Copy link
Contributor

github-actions bot commented Dec 13, 2024

size-limit report 📦

Path Size % Change Change
⛔️ @sentry/browser (max: 23.44 KB) 23.45 KB +0.73% +172 B 🔺
@sentry/browser - with treeshaking flags 22.11 KB +0.7% +156 B 🔺
@sentry/browser (incl. Tracing) 35.95 KB +0.45% +163 B 🔺
@sentry/browser (incl. Tracing, Replay) 73.2 KB +0.24% +174 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.56 KB +0.24% +150 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.61 KB +0.22% +167 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.98 KB +0.16% +147 B 🔺
⛔️ @sentry/browser (incl. Feedback) (max: 40.04 KB) 40.2 KB +0.41% +167 B 🔺
@sentry/browser (incl. sendFeedback) 28.06 KB +0.6% +169 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.84 KB +0.49% +163 B 🔺
@sentry/react 26.14 KB +0.7% +184 B 🔺
@sentry/react (incl. Tracing) 38.77 KB +0.45% +174 B 🔺
@sentry/vue 27.65 KB +0.58% +163 B 🔺
@sentry/vue (incl. Tracing) 37.77 KB +0.4% +153 B 🔺
@sentry/svelte 23.62 KB +0.73% +173 B 🔺
CDN Bundle 24.56 KB +0.54% +135 B 🔺
CDN Bundle (incl. Tracing) 37.58 KB +0.35% +131 B 🔺
CDN Bundle (incl. Tracing, Replay) 72.68 KB +0.2% +142 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 78.07 KB +0.18% +138 B 🔺
CDN Bundle - uncompressed 72.11 KB +0.51% +373 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 111.42 KB +0.34% +379 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.47 KB +0.17% +379 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.68 KB +0.16% +375 B 🔺
@sentry/nextjs (client) 39.03 KB +0.4% +159 B 🔺
@sentry/sveltekit (client) 36.45 KB +0.44% +160 B 🔺
@sentry/node 162.22 KB -0.33% -546 B 🔽
@sentry/node - without tracing 98.36 KB -0.54% -542 B 🔽
@sentry/aws-serverless 126.09 KB -0.43% -555 B 🔽

View base workflow run

Copy link

codecov bot commented Dec 13, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
691 1 690 300
View the top 1 failed tests by shortest run time
public-api/debug/test.ts logs debug messages correctly
Stack Traces | 0.222s run time
test.ts:7:11 logs debug messages correctly

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

mydea and others added 7 commits December 13, 2024 13:37
In order for us to have size-limit comparison etc, we need to ensure CI
runs on v8 & v9 branches too.
With this PR, the default value for the `spans` option in the
`httpIntegration` is changed to `false`, if `skipOpenTelemetrySetup:
true` is configured. This is what you'd expect as a user, you do not
want Sentry to register any OTEL instrumentation and emit any spans in
this scenario.

Closes #14675
@lforst lforst changed the base branch from v9 to develop December 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants