ref: Remove some unnecessary conditions #14698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Dec 13, 2024
| @@ -179,7 +179,7 @@ export function applyDebugIds(event: Event, stackParser: StackParser): void { | |||
| event!.exception!.values!.forEach(exception => { | |||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |||
| exception.stacktrace!.frames!.forEach(frame => { | |||
| if (filenameDebugIdMap && frame.filename) { | |||
| if (frame.filename) { | |||
There was a problem hiding this comment.
all of this is try-catched anyhow.
mydea
commented
Dec 13, 2024
| throw new Error('Missing "name" for scheduled job. A name is required for Sentry check-in monitoring.'); | ||
| } | ||
|
|
||
| async function monitoredCallback(): Promise<void> { | ||
| const monitoredCallback = async (): Promise<void> => { |
There was a problem hiding this comment.
@AbhiPrasad (I think you worked on this initially) is it important that this is not an arrow function? Without this, it complains about stuff being mutateable as this is hoisted, I guess.
There was a problem hiding this comment.
arrow function should be fine, it shouldn't rely on the this context.
size-limit report 📦
|
mydea
force-pushed
the
fn/remove-some-unnecessary-conditions
branch
from
d5ec64c to
1713ea7
Compare
AbhiPrasad
approved these changes
Dec 13, 2024
| throw new Error('Missing "name" for scheduled job. A name is required for Sentry check-in monitoring.'); | ||
| } | ||
|
|
||
| async function monitoredCallback(): Promise<void> { | ||
| const monitoredCallback = async (): Promise<void> => { |
There was a problem hiding this comment.
arrow function should be fine, it shouldn't rely on the this context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with finally enabling the no-unnecessary-condition eslint rule, and figured to start fixing some of the stuff it found. These should mostly be straightforward things, or in some cases I adjusted tests to ensure we "correctly" check for stuff.