fix(react): Use Set as the allRoutes container.
#14878
Merged
+520
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/react-router-recursion-break
branch
from
80b9537 to
b925c14
Compare
s1gr1d
approved these changes
Jan 2, 2025
Co-authored-by: Sigrid Huemer <[email protected]>
chargome
approved these changes
Jan 2, 2025
|
Nice! Could we get this released by any chance? 🙏🏻 |
chargome
added a commit
that referenced
this pull request
Jan 7, 2025
backport of #14878 Co-authored-by: Onur Temizkan <[email protected]>
|
@Bartozzz we'll cut a release today |
This was referenced Jan 7, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #14848
Resolves: #14877
I believe this PR should resolve the issues above, but I am still unable to reproduce them.
We can follow up this PR with new tests when we get to reproduce.