feat(nextjs): Ensure all packages we auto-instrument are externalized #16552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So they can be instrumented by us.
AbhiPrasad
approved these changes
Jun 11, 2025
chargome
reviewed
Jun 12, 2025
| @@ -229,6 +258,10 @@ function getFinalConfigObject( | |||
|
|
|||
| return { | |||
| ...incomingUserNextConfigObject, | |||
| serverExternalPackages: [ | |||
There was a problem hiding this comment.
m: before v15.0.0 this was called serverComponentsExternalPackages, we probably want to make this version dependant 😬
There was a problem hiding this comment.
argh! Can you just push this change on top of this branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So they can be instrumented by us.
I think this should be fine and not really affect users, hopefully, since Next.js itself also does this already for common packages.
Closes #16550