ref(browser-utils): Align standalone LCP span attribute setting with pageload span LCP attributes #16844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up from #16591: As identified by cursor (lol), our way of setting the
lcp.*
attributes wasn't 100% aligned with how and when we set these attributes on the pageload span. This PR changes two things:lcp.url
if it is longer than 200 characterslcp.size
ifentry.size === 0
(which previously was falsy and hence not added)