✨ Add Typer integration #3869
Open
✨ Add Typer integration #3869
+122
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an integration for Typer
The integration works by mocking
typer.main.except_hook, I was chatting with Sebastian and he's willing to add a hook in typer to avoid mocking, but I think it's also fine to keep the code as is 😊The code is inspired by the
ExcepthookIntegration, same thing for the test, unfortunately there's no way to test a custom except_hook with pytest, so I'm running the CLI using subprocess.Shall I add this to the default integrations? 😊
Closes #1612
Closes #1604