Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(1) feat: Add Feedback From Component #4328
base: main
Are you sure you want to change the base?
(1) feat: Add Feedback From Component #4328
Changes from 59 commits
817eac8
5370a99
42e2fa1
514b102
0935bbd
9ea5496
da0d4ac
3e36c6d
5f3df64
71b28e8
f9d2b59
d05d531
2bb104b
4339274
6ce799b
f2cefc6
694ee33
18b1c33
034efde
67a492d
8eaa61d
0b88cc5
ae11b8d
7f2ca06
064b6c4
e2add4a
e21718a
407f179
14ac005
ddade00
1bc1e4c
7934756
95e1e0f
a169362
4b5df7a
4fa81ce
4fff82f
0258bf2
458ebc2
f0e1bef
b9235f2
6717a84
39a67bd
501a134
4b290a2
7109deb
c80c5cb
8c56753
d6e9229
5292475
efd809f
bc7ae65
79ee5ba
ba13320
1f5fb56
439367a
9831482
4097347
f8a82fd
30a7b10
3eccf25
bc96fce
995a9ca
3aacaf7
20e3a6c
78e412c
c45a5e6
6e39119
57d99e9
6fb8ab4
fd2e317
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's match the default with JS.
Mainly I've noticed submitButton backgroundColor (JS has
rgba(88, 74, 192, 1)
) and test color#2b2233
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to align with the light theme of JS with 30a7b10
Screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a personal preference, but I would make both the button bold or both regular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with 3aacaf7 to use regular fonts weight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are using custom regex for the email validation, let's add an option to enable/disable the validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an option with c45a5e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let do the merge only once
{ ...defaultConfiguration, ...this.props }
.On moder devices it should not make a perf difference, but let's be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea 👍
Updated with 6e39119
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the configuration parameters used are copied from the JS APi https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/types-hoist/feedback/config.ts