Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): Replace release bot with GH app #4354

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Jeffreyhung
Copy link
Member

The getsentry-release is a GitHub bot account that is used in various automation, and the ${{ secrets.GH_RELEASE_PAT }} is a personal access token from that bot account. We are using a regular GitHub account as a bot while it should be a non-human account since there are no humans behind it. Hence, we are replacing it with a GitHub App.

Functionality wise, there will be no difference.

More details: https://www.notion.so/sentry/DACI-Replace-GitHub-bot-accounts-with-GitHub-Apps-getsentry-release-15109965d1204a91b9be71c49e8b66e0?pvs=4

#skip-changelog

Copy link
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 78c6ec9

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 399.22 ms 448.82 ms 49.60 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4a6664f+dirty 357.02 ms 394.91 ms 37.89 ms
22e31b6+dirty 295.75 ms 346.73 ms 50.98 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
7fd512a+dirty 439.69 ms 503.71 ms 64.01 ms
8de2810+dirty 368.43 ms 412.20 ms 43.77 ms
d361d38+dirty 257.72 ms 318.76 ms 61.04 ms
52c0562+dirty 401.23 ms 435.65 ms 34.42 ms
148f924+dirty 347.36 ms 389.13 ms 41.77 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
7bc4d75+dirty 420.96 ms 472.25 ms 51.29 ms

App size

Revision Plain With Sentry Diff
4a6664f+dirty 7.15 MiB 8.22 MiB 1.07 MiB
22e31b6+dirty 7.15 MiB 8.10 MiB 981.29 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
7fd512a+dirty 7.15 MiB 8.35 MiB 1.21 MiB
8de2810+dirty 7.15 MiB 8.35 MiB 1.20 MiB
d361d38+dirty 7.15 MiB 8.08 MiB 959.34 KiB
52c0562+dirty 7.15 MiB 8.39 MiB 1.24 MiB
148f924+dirty 7.15 MiB 8.21 MiB 1.07 MiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
7bc4d75+dirty 7.15 MiB 8.35 MiB 1.20 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.78 ms 1229.17 ms 4.39 ms
Size 2.36 MiB 3.11 MiB 759.86 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c639edf+dirty 1236.18 ms 1235.04 ms -1.14 ms
b8ff156+dirty 1236.51 ms 1234.53 ms -1.98 ms
484813b+dirty 1222.45 ms 1220.79 ms -1.66 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
77680ec+dirty 1231.81 ms 1238.35 ms 6.54 ms
0677344+dirty 1276.70 ms 1300.07 ms 23.37 ms
63ed251+dirty 1232.55 ms 1238.77 ms 6.22 ms
8c88ac7+dirty 1205.13 ms 1218.87 ms 13.74 ms
5446992+dirty 1273.28 ms 1276.68 ms 3.40 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms

App size

Revision Plain With Sentry Diff
c639edf+dirty 2.36 MiB 3.08 MiB 736.63 KiB
b8ff156+dirty 2.36 MiB 3.11 MiB 759.80 KiB
484813b+dirty 2.36 MiB 3.08 MiB 734.18 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
77680ec+dirty 2.36 MiB 3.10 MiB 753.42 KiB
0677344+dirty 2.36 MiB 2.85 MiB 496.81 KiB
63ed251+dirty 2.36 MiB 3.10 MiB 752.55 KiB
8c88ac7+dirty 2.36 MiB 3.10 MiB 752.63 KiB
5446992+dirty 2.36 MiB 2.88 MiB 531.94 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.18 ms 1235.35 ms -0.84 ms
Size 2.92 MiB 3.67 MiB 772.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c639edf+dirty 1223.63 ms 1227.98 ms 4.35 ms
b8ff156+dirty 1238.92 ms 1239.57 ms 0.66 ms
484813b+dirty 1225.07 ms 1221.00 ms -4.07 ms
12427f4+dirty 1224.90 ms 1231.40 ms 6.50 ms
77680ec+dirty 1237.65 ms 1236.24 ms -1.41 ms
0677344+dirty 1252.52 ms 1254.08 ms 1.56 ms
63ed251+dirty 1223.27 ms 1222.94 ms -0.33 ms
8c88ac7+dirty 1240.66 ms 1247.42 ms 6.76 ms
5446992+dirty 1249.94 ms 1254.80 ms 4.86 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms

App size

Revision Plain With Sentry Diff
c639edf+dirty 2.92 MiB 3.64 MiB 742.55 KiB
b8ff156+dirty 2.92 MiB 3.67 MiB 772.38 KiB
484813b+dirty 2.92 MiB 3.64 MiB 740.56 KiB
12427f4+dirty 2.92 MiB 3.44 MiB 533.29 KiB
77680ec+dirty 2.92 MiB 3.66 MiB 758.54 KiB
0677344+dirty 2.92 MiB 3.41 MiB 500.94 KiB
63ed251+dirty 2.92 MiB 3.66 MiB 757.10 KiB
8c88ac7+dirty 2.92 MiB 3.66 MiB 757.12 KiB
5446992+dirty 2.92 MiB 3.44 MiB 535.26 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB

@Jeffreyhung Jeffreyhung requested a review from BYK December 11, 2024 17:05
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krystofwoldrich Do also need the same PR for the branch v5?

In regard to the main, LGTM!

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 470.38 ms 452.58 ms -17.79 ms
Size 17.74 MiB 20.09 MiB 2.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e22745e 462.66 ms 458.10 ms -4.56 ms
70e6261 482.65 ms 495.70 ms 13.05 ms
575f9da 415.26 ms 422.98 ms 7.72 ms
e5bc97b 438.96 ms 437.39 ms -1.57 ms
77680ec 482.22 ms 475.07 ms -7.16 ms
e1ea4a8 506.82 ms 510.48 ms 3.66 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
13f280b 486.16 ms 472.45 ms -13.71 ms
12427f4 393.69 ms 414.84 ms 21.14 ms
abb7058 370.27 ms 389.58 ms 19.31 ms

App size

Revision Plain With Sentry Diff
e22745e 17.74 MiB 20.08 MiB 2.34 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB
575f9da 17.73 MiB 19.83 MiB 2.10 MiB
e5bc97b 17.74 MiB 20.08 MiB 2.34 MiB
77680ec 17.74 MiB 20.08 MiB 2.34 MiB
e1ea4a8 17.74 MiB 20.08 MiB 2.34 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
13f280b 17.74 MiB 20.08 MiB 2.34 MiB
12427f4 17.73 MiB 19.85 MiB 2.12 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB

@Jeffreyhung Jeffreyhung merged commit a84dace into main Dec 12, 2024
63 checks passed
@Jeffreyhung Jeffreyhung deleted the Replace-release-bot-with-GH-app branch December 12, 2024 18:23
@Jeffreyhung
Copy link
Member Author

@lucas-zimerman @krystofwoldrich I can have another PR up if we figured we need one for the other branch too!
Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants