Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(2.3) Auto-inject feedback widget #4370

Open
wants to merge 3 commits into
base: antonis/3859-newCaptureFeedbackAPI-Form
Choose a base branch
from
Open

(2.3) Auto-inject feedback widget #4370

wants to merge 3 commits into from
+52 −2

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Dec 13, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Exports a showFeedbackForm method that can be used to show the form directly

💡 Motivation and Context

Fixes #4358

💚 How did you test it?

Manual testing with the 'Feedback form (autoinject)' buton in the sample app

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis mentioned this pull request Dec 13, 2024
Open
10 tasks
@antonis antonis marked this pull request as ready for review December 13, 2024 12:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 478.06 ms 464.21 ms -13.85 ms
Size 17.74 MiB 20.10 MiB 2.36 MiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI-Form

Startup times

Revision Plain With Sentry Diff
27e1bf3 463.19 ms 478.80 ms 15.61 ms
0781f75 452.32 ms 457.22 ms 4.91 ms
a3ba405 438.16 ms 435.78 ms -2.38 ms
a06f6ba 424.02 ms 415.82 ms -8.20 ms
d33790a 442.93 ms 439.94 ms -3.00 ms
561640f 461.96 ms 458.11 ms -3.85 ms
cadf235 462.20 ms 463.34 ms 1.14 ms
26fc306 426.80 ms 421.58 ms -5.22 ms
50c70c0 496.82 ms 526.02 ms 29.20 ms

App size

Revision Plain With Sentry Diff
27e1bf3 17.74 MiB 20.09 MiB 2.35 MiB
0781f75 17.74 MiB 20.09 MiB 2.35 MiB
a3ba405 17.74 MiB 20.09 MiB 2.35 MiB
a06f6ba 17.74 MiB 20.09 MiB 2.35 MiB
d33790a 17.74 MiB 20.10 MiB 2.36 MiB
561640f 17.74 MiB 20.09 MiB 2.35 MiB
cadf235 17.74 MiB 20.09 MiB 2.35 MiB
26fc306 17.74 MiB 20.09 MiB 2.35 MiB
50c70c0 17.74 MiB 20.10 MiB 2.36 MiB

Previous results on branch: antonis/4358-Feedback-Form-Autoinject

Startup times

Revision Plain With Sentry Diff
068e9ea 363.11 ms 362.36 ms -0.75 ms
a511abb 442.88 ms 434.45 ms -8.43 ms

App size

Revision Plain With Sentry Diff
068e9ea 17.74 MiB 20.10 MiB 2.36 MiB
a511abb 17.74 MiB 20.10 MiB 2.36 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.09 ms 1223.06 ms 6.97 ms
Size 2.36 MiB 3.11 MiB 761.17 KiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI-Form

Startup times

Revision Plain With Sentry Diff
a3ba405+dirty 1223.00 ms 1219.06 ms -3.94 ms
a06f6ba+dirty 1230.45 ms 1227.09 ms -3.36 ms
50c70c0+dirty 1228.06 ms 1224.43 ms -3.64 ms
d33790a+dirty 1234.19 ms 1231.76 ms -2.43 ms
cadf235+dirty 1223.89 ms 1236.22 ms 12.33 ms
27e1bf3+dirty 1230.92 ms 1232.33 ms 1.41 ms
0781f75+dirty 1222.19 ms 1222.11 ms -0.08 ms
26fc306+dirty 1227.25 ms 1225.85 ms -1.40 ms
561640f+dirty 1220.45 ms 1227.02 ms 6.57 ms

App size

Revision Plain With Sentry Diff
a3ba405+dirty 2.36 MiB 3.11 MiB 760.99 KiB
a06f6ba+dirty 2.36 MiB 3.11 MiB 761.35 KiB
50c70c0+dirty 2.36 MiB 3.11 MiB 760.92 KiB
d33790a+dirty 2.36 MiB 3.11 MiB 761.06 KiB
cadf235+dirty 2.36 MiB 3.11 MiB 761.47 KiB
27e1bf3+dirty 2.36 MiB 3.11 MiB 761.03 KiB
0781f75+dirty 2.36 MiB 3.11 MiB 761.35 KiB
26fc306+dirty 2.36 MiB 3.11 MiB 761.18 KiB
561640f+dirty 2.36 MiB 3.11 MiB 761.19 KiB

Previous results on branch: antonis/4358-Feedback-Form-Autoinject

Startup times

Revision Plain With Sentry Diff
068e9ea+dirty 1240.31 ms 1234.70 ms -5.62 ms
a511abb+dirty 1223.38 ms 1225.08 ms 1.71 ms

App size

Revision Plain With Sentry Diff
068e9ea+dirty 2.36 MiB 3.11 MiB 761.04 KiB
a511abb+dirty 2.36 MiB 3.11 MiB 761.04 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 380.79 ms 405.19 ms 24.40 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI-Form

Startup times

Revision Plain With Sentry Diff
a3ba405+dirty 359.67 ms 436.86 ms 77.19 ms
26fc306+dirty 382.83 ms 435.31 ms 52.48 ms
0781f75+dirty 406.72 ms 454.80 ms 48.08 ms
a06f6ba+dirty 381.50 ms 429.77 ms 48.27 ms
50c70c0+dirty 385.30 ms 433.06 ms 47.76 ms
561640f+dirty 378.73 ms 442.25 ms 63.52 ms
27e1bf3+dirty 398.69 ms 439.39 ms 40.69 ms
cadf235+dirty 455.51 ms 451.64 ms -3.87 ms
d33790a+dirty 404.87 ms 473.06 ms 68.19 ms

App size

Revision Plain With Sentry Diff
a3ba405+dirty 7.15 MiB 8.37 MiB 1.22 MiB
26fc306+dirty 7.15 MiB 8.37 MiB 1.22 MiB
0781f75+dirty 7.15 MiB 8.37 MiB 1.22 MiB
a06f6ba+dirty 7.15 MiB 8.37 MiB 1.22 MiB
50c70c0+dirty 7.15 MiB 8.38 MiB 1.23 MiB
561640f+dirty 7.15 MiB 8.37 MiB 1.22 MiB
27e1bf3+dirty 7.15 MiB 8.37 MiB 1.22 MiB
cadf235+dirty 7.15 MiB 8.37 MiB 1.22 MiB
d33790a+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Previous results on branch: antonis/4358-Feedback-Form-Autoinject

Startup times

Revision Plain With Sentry Diff
a511abb+dirty 376.44 ms 431.64 ms 55.20 ms
068e9ea+dirty 363.19 ms 396.49 ms 33.30 ms

App size

Revision Plain With Sentry Diff
a511abb+dirty 7.15 MiB 8.38 MiB 1.23 MiB
068e9ea+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1248.58 ms 1247.53 ms -1.05 ms
Size 2.92 MiB 3.67 MiB 773.74 KiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI-Form

Startup times

Revision Plain With Sentry Diff
a3ba405+dirty 1229.31 ms 1228.16 ms -1.14 ms
a06f6ba+dirty 1235.31 ms 1238.76 ms 3.45 ms
50c70c0+dirty 1226.61 ms 1225.02 ms -1.59 ms
d33790a+dirty 1247.14 ms 1242.86 ms -4.28 ms
cadf235+dirty 1225.19 ms 1231.65 ms 6.47 ms
27e1bf3+dirty 1245.78 ms 1244.38 ms -1.40 ms
0781f75+dirty 1247.90 ms 1237.11 ms -10.79 ms
26fc306+dirty 1229.10 ms 1227.88 ms -1.22 ms
561640f+dirty 1237.10 ms 1229.59 ms -7.51 ms

App size

Revision Plain With Sentry Diff
a3ba405+dirty 2.92 MiB 3.67 MiB 773.65 KiB
a06f6ba+dirty 2.92 MiB 3.67 MiB 773.87 KiB
50c70c0+dirty 2.92 MiB 3.67 MiB 773.48 KiB
d33790a+dirty 2.92 MiB 3.67 MiB 773.59 KiB
cadf235+dirty 2.92 MiB 3.67 MiB 773.97 KiB
27e1bf3+dirty 2.92 MiB 3.67 MiB 773.54 KiB
0781f75+dirty 2.92 MiB 3.67 MiB 773.83 KiB
26fc306+dirty 2.92 MiB 3.67 MiB 773.77 KiB
561640f+dirty 2.92 MiB 3.67 MiB 773.72 KiB

Previous results on branch: antonis/4358-Feedback-Form-Autoinject

Startup times

Revision Plain With Sentry Diff
068e9ea+dirty 1224.21 ms 1225.36 ms 1.15 ms
a511abb+dirty 1243.58 ms 1239.15 ms -4.44 ms

App size

Revision Plain With Sentry Diff
068e9ea+dirty 2.92 MiB 3.67 MiB 773.56 KiB
a511abb+dirty 2.92 MiB 3.67 MiB 773.59 KiB

@antonis antonis linked an issue Dec 13, 2024 that may be closed by this pull request
Autoinject feedback widget #4358
Open
@antonis
Merge branch 'antonis/3859-newCaptureFeedbackAPI-Form' into antonis/4…
8b9f4d5 
…358-Feedback-Form-Autoinject

# Conflicts:
#	CHANGELOG.md
@krystofwoldrich krystofwoldrich changed the title Auto-inject feedback widget (2.3) Auto-inject feedback widget Dec 13, 2024
@antonis
Merge branch 'antonis/3859-newCaptureFeedbackAPI-Form' into antonis/4…
0261e04 
…358-Feedback-Form-Autoinject

# Conflicts:
#	packages/core/src/js/feedback/FeedbackForm.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autoinject feedback widget
1 participant
@antonis