-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Upgrade performance test apps to RN 0.77 #4515
Draft
antonis
wants to merge
12
commits into
main
Choose a base branch
from
antonis/performanceapps-rn0.77
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a big bump in the Android binary size and and binary size diff that needs to be investagated
|
Yeah, we should look into the Android diff before we merge this. It's strange that the app with Sentry is now almost 6 MiB larger and before it was ~2 MiB. Let's investigate the differences in the artifacts, and see what is causing the difference. |
# Conflicts: # performance-tests/TestAppSentry/package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR bumps the performance test apps to RN 0.77.
Note that I recreated the apps for 0.77 due to the extended upgrade diff and the fact that the apps did not have any major customisations.
Diff: RnDiffApp 0.70.15 vs TestAppPlain
Diff: TestAppPlain vs TestAppSentry
💡 Motivation and Context
Fixes #4426
💚 How did you test it?
Manua, CI
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps
#skip-changelog