Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Fixes JS SDK v9 breakages #4566

Closed
wants to merge 9 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Feb 19, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #4528

📜 Description

I've opened this PR to fix JS SDK v9 breakages without interfering with the update-javascript.sh ci automation and to get a 2nd eye on the changes.

Changes handled:

💡 Motivation and Context

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 309.44 ms 330.69 ms 21.25 ms
Size 17.75 MiB 20.10 MiB 2.36 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
2b518a4 416.96 ms 419.80 ms 2.84 ms
adf3982 425.40 ms 405.88 ms -19.52 ms
f193e90 432.83 ms 433.10 ms 0.27 ms
fcac744 515.94 ms 507.66 ms -8.28 ms
1e9894e 431.94 ms 445.06 ms 13.12 ms
77069a3 341.91 ms 358.43 ms 16.52 ms
ce14fde 465.58 ms 454.73 ms -10.85 ms
727778d 472.20 ms 462.50 ms -9.70 ms
ff80bc5 332.24 ms 329.44 ms -2.79 ms
1428daf 432.50 ms 416.16 ms -16.34 ms

App size

Revision Plain With Sentry Diff
2b518a4 17.75 MiB 20.11 MiB 2.37 MiB
adf3982 17.74 MiB 20.08 MiB 2.35 MiB
f193e90 17.74 MiB 20.08 MiB 2.34 MiB
fcac744 17.74 MiB 20.10 MiB 2.36 MiB
1e9894e 17.74 MiB 20.08 MiB 2.34 MiB
77069a3 17.74 MiB 20.08 MiB 2.35 MiB
ce14fde 17.74 MiB 20.08 MiB 2.35 MiB
727778d 17.74 MiB 20.09 MiB 2.35 MiB
ff80bc5 17.75 MiB 20.11 MiB 2.37 MiB
1428daf 17.74 MiB 20.08 MiB 2.35 MiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 410.04 ms 396.82 ms -13.22 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
6bbb5e8+dirty 372.67 ms 426.37 ms 53.69 ms
ff80bc5+dirty 388.34 ms 419.56 ms 31.22 ms
2fa2dd4+dirty 410.71 ms 460.00 ms 49.29 ms
88a5c10+dirty 387.13 ms 438.66 ms 51.53 ms
1428daf+dirty 413.94 ms 472.71 ms 58.77 ms
c0332a6+dirty 389.21 ms 449.39 ms 60.17 ms
727778d+dirty 379.36 ms 416.67 ms 37.32 ms
fcac744+dirty 370.23 ms 413.69 ms 43.46 ms
adf3982+dirty 407.54 ms 468.67 ms 61.12 ms
ee6386c+dirty 381.81 ms 426.33 ms 44.52 ms

App size

Revision Plain With Sentry Diff
6bbb5e8+dirty 7.15 MiB 8.37 MiB 1.22 MiB
ff80bc5+dirty 7.15 MiB 8.38 MiB 1.23 MiB
2fa2dd4+dirty 7.15 MiB 8.38 MiB 1.23 MiB
88a5c10+dirty 7.15 MiB 8.36 MiB 1.21 MiB
1428daf+dirty 7.15 MiB 8.37 MiB 1.22 MiB
c0332a6+dirty 7.15 MiB 8.35 MiB 1.20 MiB
727778d+dirty 7.15 MiB 8.37 MiB 1.22 MiB
fcac744+dirty 7.15 MiB 8.37 MiB 1.22 MiB
adf3982+dirty 7.15 MiB 8.37 MiB 1.22 MiB
ee6386c+dirty 7.15 MiB 8.37 MiB 1.22 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.08 ms 1232.06 ms 1.98 ms
Size 2.63 MiB 3.73 MiB 1.10 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
cdeca8b+dirty 1212.42 ms 1223.69 ms 11.27 ms
88a5c10+dirty 1242.02 ms 1249.54 ms 7.52 ms
965cf9f+dirty 1237.92 ms 1234.81 ms -3.11 ms
29d1f5b+dirty 1231.75 ms 1240.86 ms 9.11 ms
e4c23be+dirty 1225.25 ms 1223.76 ms -1.49 ms
d5790fb+dirty 1237.59 ms 1239.83 ms 2.23 ms
1428daf+dirty 1231.58 ms 1226.54 ms -5.04 ms
0ce9e4f+dirty 1226.02 ms 1229.73 ms 3.71 ms
adf3982+dirty 1231.80 ms 1232.20 ms 0.41 ms
57faccb+dirty 1240.02 ms 1241.56 ms 1.54 ms

App size

Revision Plain With Sentry Diff
cdeca8b+dirty 2.36 MiB 3.09 MiB 743.02 KiB
88a5c10+dirty 2.36 MiB 3.10 MiB 753.52 KiB
965cf9f+dirty 2.36 MiB 3.11 MiB 761.34 KiB
29d1f5b+dirty 2.36 MiB 3.12 MiB 778.61 KiB
e4c23be+dirty 2.36 MiB 3.08 MiB 737.17 KiB
d5790fb+dirty 2.63 MiB 3.69 MiB 1.05 MiB
1428daf+dirty 2.36 MiB 3.10 MiB 759.42 KiB
0ce9e4f+dirty 2.36 MiB 3.10 MiB 759.36 KiB
adf3982+dirty 2.36 MiB 3.10 MiB 759.41 KiB
57faccb+dirty 2.36 MiB 3.11 MiB 760.10 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.90 ms 1237.16 ms 1.27 ms
Size 3.19 MiB 4.30 MiB 1.11 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
cdeca8b+dirty 1235.78 ms 1225.23 ms -10.55 ms
88a5c10+dirty 1244.39 ms 1238.30 ms -6.09 ms
965cf9f+dirty 1224.78 ms 1242.71 ms 17.94 ms
29d1f5b+dirty 1233.35 ms 1226.16 ms -7.19 ms
e4c23be+dirty 1232.21 ms 1230.16 ms -2.05 ms
d5790fb+dirty 1227.04 ms 1234.14 ms 7.10 ms
1428daf+dirty 1235.27 ms 1237.24 ms 1.98 ms
0ce9e4f+dirty 1237.40 ms 1238.87 ms 1.47 ms
adf3982+dirty 1243.14 ms 1242.96 ms -0.18 ms
57faccb+dirty 1242.55 ms 1239.17 ms -3.38 ms

App size

Revision Plain With Sentry Diff
cdeca8b+dirty 2.92 MiB 3.64 MiB 744.52 KiB
88a5c10+dirty 2.92 MiB 3.66 MiB 758.74 KiB
965cf9f+dirty 2.92 MiB 3.67 MiB 773.95 KiB
29d1f5b+dirty 2.92 MiB 3.69 MiB 789.93 KiB
e4c23be+dirty 2.92 MiB 3.64 MiB 742.98 KiB
d5790fb+dirty 3.19 MiB 4.25 MiB 1.06 MiB
1428daf+dirty 2.92 MiB 3.67 MiB 772.07 KiB
0ce9e4f+dirty 2.92 MiB 3.67 MiB 771.89 KiB
adf3982+dirty 2.92 MiB 3.67 MiB 772.04 KiB
57faccb+dirty 2.92 MiB 3.67 MiB 772.55 KiB

@antonis
Copy link
Collaborator Author

antonis commented Feb 19, 2025

Closing in favour of #4568 that targets v7

@antonis antonis closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant