Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumbs with warn level not being ingested #2150

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

sl0thentr0py
Copy link
Member

Fixes #2145

@sl0thentr0py sl0thentr0py marked this pull request as ready for review October 23, 2023 13:16
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2150 (10d3bfe) into master (1c0550f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2150      +/-   ##
==========================================
+ Coverage   97.27%   97.30%   +0.02%     
==========================================
  Files          97       97              
  Lines        3630     3632       +2     
==========================================
+ Hits         3531     3534       +3     
+ Misses         99       98       -1     
Components Coverage Δ
sentry-ruby 97.98% <100.00%> (+<0.01%) ⬆️
sentry-rails 94.96% <ø> (ø)
sentry-sidekiq 93.70% <ø> (ø)
sentry-resque 93.65% <ø> (+1.58%) ⬆️
sentry-delayed_job 94.36% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/breadcrumb.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit 730c44a into master Oct 23, 2023
@sl0thentr0py sl0thentr0py deleted the neel/fix-breadcrumb-warn branch October 23, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discarded invalid value in Ruby events
2 participants