Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report dropped spans in client reports #2346

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jul 19, 2024

  • In addition to transactions, we want to also count all potential span drops individually in Client Reports
  • This is helpful for collecting stats and for customer support for our new span based pricing model

closes #2341

@sl0thentr0py sl0thentr0py force-pushed the neel/span-client-reports branch from a7e0c34 to 7639fdc Compare July 19, 2024 10:25
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (36866c5) to head (8ae78fb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2346      +/-   ##
==========================================
- Coverage   98.66%   98.66%   -0.01%     
==========================================
  Files         205      205              
  Lines       13483    13546      +63     
==========================================
+ Hits        13303    13365      +62     
- Misses        180      181       +1     
Components Coverage Δ
sentry-ruby 99.02% <100.00%> (-0.01%) ⬇️
sentry-rails 97.41% <ø> (ø)
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 96.79% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/client.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/envelope.rb 98.33% <100.00%> (ø)
sentry-ruby/lib/sentry/transaction.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/transport.rb 99.04% <100.00%> (ø)
...ntry-ruby/spec/sentry/client/event_sending_spec.rb 99.68% <100.00%> (+0.05%) ⬆️
sentry-ruby/spec/sentry/envelope_spec.rb 100.00% <ø> (ø)
sentry-ruby/spec/sentry/transaction_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/transport_spec.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/span-client-reports branch 2 times, most recently from a7c42c9 to f4c812b Compare July 19, 2024 11:53
@sl0thentr0py sl0thentr0py requested a review from solnic July 19, 2024 11:53
@sl0thentr0py sl0thentr0py force-pushed the neel/span-client-reports branch from f4c812b to 8ae78fb Compare July 19, 2024 11:55
Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor suggestions, otherwise LGTM!

@sl0thentr0py sl0thentr0py force-pushed the neel/span-client-reports branch from 8ae78fb to 73a27e1 Compare July 23, 2024 13:15
@sl0thentr0py sl0thentr0py force-pushed the neel/span-client-reports branch from 73a27e1 to 7c0b880 Compare July 23, 2024 13:17
@sl0thentr0py sl0thentr0py merged commit c785d04 into master Jul 23, 2024
123 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/span-client-reports branch July 23, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report dropped spans in client reports
2 participants