Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper limit on graphql gem version #2362

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Aug 5, 2024

The original issue should've been addressed in rmosolgo/graphql-ruby#5052 and released in v2.3.12

(Found rmosolgo/graphql-ruby#5050 (comment) when checking #2360)

#skip-changelog

@st0012 st0012 marked this pull request as ready for review August 5, 2024 22:23
@st0012 st0012 requested a review from solnic August 5, 2024 22:23
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (ef1eeb3) to head (da5b783).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2362   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files         208      208           
  Lines       13748    13748           
=======================================
  Hits        13568    13568           
  Misses        180      180           
Components Coverage Δ
sentry-ruby 99.05% <ø> (ø)
sentry-rails 97.41% <ø> (ø)
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 96.79% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)

@st0012 st0012 merged commit e4571d9 into master Aug 6, 2024
129 of 130 checks passed
@st0012 st0012 deleted the release-graphql-lock branch August 6, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants