Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jar-dependencies for jruby CI #2482

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Pin jar-dependencies for jruby CI #2482

merged 1 commit into from
Dec 3, 2024

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Dec 3, 2024

new release broke via psych, see jruby/jruby#7262 (comment)
#skip-changelog

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (0f89aa8) to head (3fc5e9f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2482      +/-   ##
==========================================
- Coverage   98.31%   98.17%   -0.14%     
==========================================
  Files         128      128              
  Lines        4807     4827      +20     
==========================================
+ Hits         4726     4739      +13     
- Misses         81       88       +7     
Components Coverage Δ
sentry-ruby 98.57% <ø> (-0.14%) ⬇️
sentry-rails 97.07% <ø> (-0.75%) ⬇️
sentry-sidekiq 96.96% <ø> (+1.73%) ⬆️
sentry-resque 92.85% <ø> (+0.21%) ⬆️
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (-0.69%) ⬇️

see 17 files with indirect coverage changes

@sl0thentr0py sl0thentr0py changed the title Fix psych mess for jruby CI Don't load psych related dev gems in jruby Dec 3, 2024
@sl0thentr0py sl0thentr0py changed the title Don't load psych related dev gems in jruby Pin psych for jruby Dec 3, 2024
@sl0thentr0py sl0thentr0py changed the title Pin psych for jruby Pin psych for jruby CI Dec 3, 2024
@sl0thentr0py sl0thentr0py changed the title Pin psych for jruby CI Pin jar-dependencies for jruby CI Dec 3, 2024
@sl0thentr0py sl0thentr0py requested review from st0012 and solnic December 3, 2024 16:32
@sl0thentr0py sl0thentr0py merged commit 4eb1dff into master Dec 3, 2024
142 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-psych-ci branch December 3, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants