Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RFC2396_PARSER explicitly to avoid the warning. #2509

Merged
merged 4 commits into from
Jan 20, 2025

Refactor uri_parser method into a constant.

bf7130d
Select commit
Loading
Failed to load commit list.
Merged

Use RFC2396_PARSER explicitly to avoid the warning. #2509

Refactor uri_parser method into a constant.
bf7130d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 20, 2025 in 1s

98.16% (+0.00%) compared to 1cd952b

View this Pull Request on Codecov

98.16% (+0.00%) compared to 1cd952b

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (1cd952b) to head (bf7130d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2509   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files         128      128           
  Lines        4848     4849    +1     
=======================================
+ Hits         4759     4760    +1     
  Misses         89       89           
Components Coverage Δ
sentry-ruby 98.54% <100.00%> (+<0.01%) ⬆️
sentry-rails 97.07% <ø> (ø)
sentry-sidekiq 97.09% <ø> (ø)
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/net/http.rb 100.00% <100.00%> (ø)