Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 8 example app #2512

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Add Rails 8 example app #2512

merged 2 commits into from
Jan 20, 2025

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jan 19, 2025

When investigating #2467, I wanted to see how sentry-rails would work with SolidQueue and other Rails 8 features, but there's no example apps to try. So this PR is the first step to add an Rails 8 example app to help us test and develop features for newer Rails apps.

#skip-changelog

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (1cd952b) to head (b0d2f3b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2512      +/-   ##
==========================================
- Coverage   98.16%   98.14%   -0.03%     
==========================================
  Files         128      128              
  Lines        4848     4848              
==========================================
- Hits         4759     4758       -1     
- Misses         89       90       +1     
Components Coverage Δ
sentry-ruby 98.54% <ø> (ø)
sentry-rails 96.91% <ø> (-0.16%) ⬇️
sentry-sidekiq 97.09% <ø> (ø)
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)

see 1 file with indirect coverage changes

@st0012 st0012 merged commit 0356728 into master Jan 20, 2025
145 of 148 checks passed
@st0012 st0012 deleted the add-rails-8-example-app branch January 20, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants