Skip to content

feat(tracing): add support for logs #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: lcian/ref/tracing
Choose a base branch
from

Conversation

lcian
Copy link
Member

@lcian lcian commented Jun 12, 2025

Adds logs support for sentry-tracing, gated by a logs feature flag.

Open question for the future:
Someone might want to capture multiple things (e.g. if you get an error event, capture both a Sentry error and an error level log).
I would like to implement this but without breaking changes.

Copy link

github-actions bot commented Jun 12, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 38c1f4f

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.64%. Comparing base (7557f30) to head (38c1f4f).
Report is 1 commits behind head on lcian/ref/tracing.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           lcian/ref/tracing     #840      +/-   ##
=====================================================
+ Coverage              73.40%   73.64%   +0.23%     
=====================================================
  Files                     64       64              
  Lines                   7682     7728      +46     
=====================================================
+ Hits                    5639     5691      +52     
+ Misses                  2043     2037       -6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}

attributes.insert("sentry.origin".to_owned(), "auto.tracing".into());

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we cannot get the sentry.message.template with tracing.

@lcian lcian marked this pull request as draft June 12, 2025 12:48
@lcian lcian marked this pull request as ready for review June 13, 2025 07:56
@lcian lcian requested a review from Swatinem June 13, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant