Skip to content

Commit

Permalink
chore(ci): Ensure Nuxt e2e tests run on ci (#721)
Browse files Browse the repository at this point in the history
* chore(ci): Ensure Nuxt e2e tests run on ci

* Fix nuxt e2e tests

* Split Nuxt-3 and Nuxt-4 runs on ci
  • Loading branch information
andreiborza authored Nov 27, 2024
1 parent 1bde610 commit 46fd0ca
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
wizard: [NextJS, Remix, Sveltekit]
wizard: [Nuxt-3, Nuct-4, NextJS, Remix, Sveltekit]
env:
SENTRY_TEST_AUTH_TOKEN: ${{ secrets.E2E_TEST_SENTRY_AUTH_TOKEN }}
SENTRY_TEST_ORG: 'sentry-javascript-sdks'
Expand Down
2 changes: 1 addition & 1 deletion e2e-tests/tests/nuxt-3.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ function testNuxtProjectConfigs(projectDir: string) {
' }',
'},',
'sourcemap: {',
' client: true',
" client: 'hidden'",
'}',
]);
});
Expand Down
4 changes: 2 additions & 2 deletions e2e-tests/tests/nuxt-4.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function testNuxtProjectSetup(projectDir: string) {
});

test('example page exists', () => {
checkFileExists(`${projectDir}'/app/pages/sentry-example-page.vue`);
checkFileExists(`${projectDir}/app/pages/sentry-example-page.vue`);
checkFileExists(`${projectDir}/server/api/sentry-example-api.ts`);
});
}
Expand All @@ -113,7 +113,7 @@ function testNuxtProjectConfigs(projectDir: string) {
' }',
'},',
'sourcemap: {',
' client: true',
" client: 'hidden'",
'}',
]);
});
Expand Down

0 comments on commit 46fd0ca

Please sign in to comment.