feat(nuxt): Add import-in-the-middle install step when using pnpm #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
6 tasks
andreiborza
force-pushed
the
ab/pnpm-install-iitm
branch
from
01fa424 to
fe726ca
Compare
andreiborza
force-pushed
the
ab/pnpm-install-iitm
branch
from
fe726ca to
9917f2f
Compare
Lms24
approved these changes
Dec 6, 2024
src/nuxt/sdk-setup.ts
Outdated
| @@ -245,4 +259,26 @@ export async function addNuxtOverrides( | |||
| await packageManager.addOverride(pkgName, pkgVersion); | |||
| } | |||
| } | |||
|
|
|||
| if (PNPM.detect()) { | |||
| // For pnpm, we probably want to install iitm | |||
There was a problem hiding this comment.
l: probably? 😅
Suggested change
| // For pnpm, we probably want to install iitm | |
| // For pnpm, we probably want to install iitm |
There was a problem hiding this comment.
We can probably remove that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on: getsentry/sentry-docs#12002 to update the trouble shooting url.
Closes: #726