fix(deps): Bump to [email protected] to resolve deprecated dependency warning
#753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/fix-deps-bump-glob-9
branch
from
77c8750 to
cfd682a
Compare
lforst
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the
globdependency from v8 to v9 to resolve a dependency deprecation warning aboutglobandinflight(a dependency ofglob).I was initially under the impression that we can only bump glob to v9 if we bump the wizard minimum node version to Node 16 due to the changelog entry. However, it seems like,
glob@9still supports Node 14.17.0 or higher as well.I checked for our usages of
globand since we always useglob.syncand don't seem to use patterns ending with/, I think we shouldn't be exposed to breaking changes.fixes #658