feat(angular): Configure source map upload. #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lms24
approved these changes
Jan 29, 2025
Comment on lines
+130
to
+178
| project: { | ||
| organization: { | ||
| id: selectedProject.organization.id, | ||
| name: selectedProject.organization.name, | ||
| slug: selectedProject.organization.slug, | ||
| }, | ||
| id: selectedProject.id, | ||
| slug: selectedProject.slug, | ||
| keys: [ | ||
| { | ||
| dsn: { | ||
| public: dsn, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| }; |
There was a problem hiding this comment.
l: not sure if I'm missing some TS problems but can we not simply assign project: selectedProject instead of re-declaring every property? feel free to ignore if this isn't easily possible. not a blocker!
There was a problem hiding this comment.
There used to be a problem there before, but apparently, not anymore. Updated, thanks for pointing!
|
@onurtemizkan one more rebase please, thanks 🙏 |
onurtemizkan
force-pushed
the
onur/angular-sourcemaps
branch
from
5dde613 to
5cb0788
Compare
|
@Lms24 - updated 👍 |
onurtemizkan
added a commit
that referenced
this pull request
Feb 5, 2025
* feat(angular): Configure source map upload. * Use `preSelectedProject` as is * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #741 - Part 4
Targeted to the epic branch.
Adds source map upload configuration
#skip-changelog