fix(eap-api): Sentry can receive val_double in addition to `val_flo…

…at` (#83566) Update plan: 1. Sentry can receive doubles and floats 2. Snuba can receive and return doubles and floats. In the case of aggregation, replace float with double. This is fine because Sentry handles the case of receiving doubles already 3. Sentry asks for doubles only --------- Co-authored-by: Rachel Chen <[email protected]>
getsentry · Jan 16, 2025 · 549d834 · 549d834
1 parent 3c75f6d
commit 549d834
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 3 deletions.
diff --git a/requirements-base.txt b/requirements-base.txt
@@ -68,7 +68,7 @@ rfc3986-validator>=0.1.1
 sentry-arroyo>=2.19.9
 sentry-kafka-schemas>=0.1.128
 sentry-ophio==1.0.0
-sentry-protos>=0.1.49
+sentry-protos>=0.1.51
 sentry-redis-tools>=0.1.7
 sentry-relay>=0.9.4
 sentry-sdk[http2]>=2.19.2

diff --git a/requirements-dev-frozen.txt b/requirements-dev-frozen.txt
@@ -190,7 +190,7 @@ sentry-forked-djangorestframework-stubs==3.15.2.post1
 sentry-forked-email-reply-parser==0.5.12.post1
 sentry-kafka-schemas==0.1.128
 sentry-ophio==1.0.0
-sentry-protos==0.1.49
+sentry-protos==0.1.51
 sentry-redis-tools==0.1.7
 sentry-relay==0.9.4
 sentry-sdk==2.19.2

diff --git a/requirements-frozen.txt b/requirements-frozen.txt
@@ -128,7 +128,7 @@ sentry-arroyo==2.19.9
 sentry-forked-email-reply-parser==0.5.12.post1
 sentry-kafka-schemas==0.1.128
 sentry-ophio==1.0.0
-sentry-protos==0.1.49
+sentry-protos==0.1.51
 sentry-redis-tools==0.1.7
 sentry-relay==0.9.4
 sentry-sdk==2.19.2

diff --git a/src/sentry/search/eap/constants.py b/src/sentry/search/eap/constants.py
@@ -33,6 +33,7 @@
 STRING = AttributeKey.TYPE_STRING
 BOOLEAN = AttributeKey.TYPE_BOOLEAN
 FLOAT = AttributeKey.TYPE_FLOAT
+DOUBLE = AttributeKey.TYPE_DOUBLE
 INT = AttributeKey.TYPE_INT
 
 # TODO: we need a datetime type

diff --git a/src/sentry/snuba/spans_rpc.py b/src/sentry/snuba/spans_rpc.py
@@ -14,6 +14,7 @@
 from sentry.search.eap.columns import ResolvedColumn, ResolvedFunction
 from sentry.search.eap.constants import (
     BOOLEAN,
+    DOUBLE,
     FLOAT,
     INT,
     MAX_ROLLUP_POINTS,
@@ -142,6 +143,8 @@ def run_table_query(
                 result_value = result.val_int
             elif resolved_column.proto_type == FLOAT:
                 result_value = result.val_float
+            elif resolved_column.proto_type == DOUBLE:
+                result_value = result.val_double
             elif resolved_column.proto_type == BOOLEAN:
                 result_value = result.val_bool
             result_value = process_value(result_value)