Fix typo and combine filter tests

getsentry · Jan 8, 2025 · c5ae60b · c5ae60b
1 parent b8d7403
commit c5ae60b
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/tests/sentry/logging/test_handler.py b/tests/sentry/logging/test_handler.py
@@ -171,29 +171,22 @@ def test_gke_emit() -> None:
 
 
 @mock.patch("random.random", lambda: 0.1)
-def test_sampling_filter_pass(caplog, debug_level):
+def test_sampling_filter(caplog, set_level_debug):
     logger = logging.getLogger(__name__)
     with filter_context(logger, [SamplingFilter(0.2)]):
         logger.info("msg1")
         logger.info("message.2")
 
-    captured_msgs = list(map(lambda r: r.msg, caplog.records))
-    assert sorted(captured_msgs) == ["message.2", "msg1"]
-
-
-@mock.patch("random.random", lambda: 0.1)
-def test_sampling_filter_filter(caplog, debug_level):
-    logger = logging.getLogger(__name__)
     with filter_context(logger, [SamplingFilter(0.05)]):
         logger.info("msg1")
         logger.info("message.2")
 
     captured_msgs = list(map(lambda r: r.msg, caplog.records))
-    assert captured_msgs == []
+    assert sorted(captured_msgs) == ["message.2", "msg1"]
 
 
 @mock.patch("random.random", lambda: 0.1)
-def test_sampling_filter_level(caplog, debug_level):
+def test_sampling_filter_level(caplog, set_level_debug):
     logger = logging.getLogger(__name__)
     with filter_context(logger, [SamplingFilter(0.05, level=logging.WARNING)]):
         logger.debug("debug")
@@ -207,7 +200,7 @@ def test_sampling_filter_level(caplog, debug_level):
 
 
 @mock.patch("random.random", lambda: 0.1)
-def test_sampling_filter_level_default(caplog, debug_level):
+def test_sampling_filter_level_default(caplog, set_level_debug):
     logger = logging.getLogger(__name__)
     with filter_context(logger, [SamplingFilter(0.05)]):
         logger.debug("debug")