-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak in_app
rules for events from Python SDK
#79482
Labels
Comments
Given the current event [1] we want to end up with this: "abs_path": "/app/python/site-packages/foo/bar.py",
- "in_app": false,
- "data": {
- "orig_in_app": 1
+ "in_app": true
} [1] {
"exception": {
"values": [
{
"stacktrace": {
"frames": [
{
"abs_path": "/app/python/site-packages/foo/__main__.py",
"in_app": false
},
{
"abs_path": "/app/python/site-packages/click/core.py",
"in_app": false
},
{
"abs_path": "/app/python/site-packages/foo/bar.py",
"in_app": false,
"data": {
"orig_in_app": 1
}
}
]
}
}
]
}
} |
We need to skip applying the rule if in_app is already set to True since the rules were only added a year ago (PR). |
Superseded by #83603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When viewing a stacktrace in Sentry, frames are marked as either
in_app
or notin_app
. Non-in-app frames are collapsed by default. The originalin_app
decision comes from the SDK; however, at the moment Sentry can't rely on thein_app
decision from the SDK and has rules for overriding it.Two things we can do about this:
site-packages
ordist-packages
. We already check this on the SDK side. Having this rule on the server side means that it sometimes overrides a higher prio decision (e.g., the user explicitly set theirin_app_include
to include the module).in_app
values and fix the underlying issues. Tracked here: Improvein_app
detection sentry-python#3682The text was updated successfully, but these errors were encountered: