Java SDK v8 onboarding #82994
Java SDK v8 onboarding #82994
Conversation
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 12.04kB (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
| { | ||
| label: t('Combine Sentry with OpenTelemetry'), | ||
| value: YesNo.YES, | ||
| }, | ||
| { | ||
| label: t('Do not use OpenTelemetry'), | ||
| value: YesNo.NO, | ||
| }, |
There was a problem hiding this comment.
I feel like the description is a bit too long. Maybe we could simplify it to just "With OpenTelemetry" and "Without OpenTelemetry"? Also, it might make sense to use a checkbox like we do for the products, though I understand this isn't a product like "Tracing" or "Errors."
There was a problem hiding this comment.
It is not visible what the options are on smaller view ports:
There was a problem hiding this comment.
Thanks @priscilawebdev, I wasn't sure how to add another checkbox, so I did it this way for now. Happy to improve it if you can point me in the right direction.
There was a problem hiding this comment.
I reflected on this, and since the checkboxes are only for product selection (e.g., Tracing), it's important to avoid confusing users. We should keep what you've implemented, as it’s similar to what we have for "Loader Script." However, the labels can definitely be shorter. How about these options?
- Use OpenTelemetry – No OpenTelemetry
- With OpenTelemetry – Without OpenTelemetry
- With OTel – Without OTel (supposing people are familiar with this abbreviation)
There was a problem hiding this comment.
Thanks, I updated the labels to "With/Without OpenTelemetry".
|
Converting this to a draft, because we only want to merge this PR once v8 of the Java SDK has been released. |
Use
sentry-opentelemetry-agentfor Java SDK v8 onboarding.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.