Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(replay): add a generic log sampling filter and sample replay ingest logs #83049

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jan 7, 2025

@aliu39 aliu39 requested a review from a team as a code owner January 7, 2025 21:36
@aliu39 aliu39 marked this pull request as draft January 7, 2025 21:36
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 7, 2025
src/sentry/logging/handlers.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #83049   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files        9423     9423           
  Lines      536492   536477   -15     
  Branches    21120    21120           
=======================================
- Hits       469899   469886   -13     
+ Misses      66233    66231    -2     
  Partials      360      360           

@aliu39 aliu39 marked this pull request as ready for review January 8, 2025 09:08
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aliu39 aliu39 merged commit df06cf4 into master Jan 8, 2025
49 checks passed
@aliu39 aliu39 deleted the aliu/logsampler branch January 8, 2025 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants