fix(insights): Opportunity score forward browser name filter #83078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
edwardgou-sentry
force-pushed
the
egou/fix/opp-score
branch
from
1fd7c0a to
89096c1
Compare
edwardgou-sentry
changed the title
edwardgou-sentry
commented
Jan 8, 2025
| @@ -1796,11 +1796,28 @@ def _resolve_total_score_weights_function(self, column: str, alias: str | None) | |||
| if column in self.total_score_weights and self.total_score_weights[column] is not None: | |||
| return Function("toFloat64", [self.total_score_weights[column]], alias) | |||
|
|
|||
| # Pull out browser.name filters from the query | |||
| parsed_terms = parse_search_query(self.builder.query) | |||
| query = " ".join( | |||
There was a problem hiding this comment.
Not sure if theres a cleaner way to do this, or if theres some function that already exists.
This code is to pull out any browser.name filters that exist on the original query, including those that are wrapped by parenthesis.
mjq
approved these changes
Jan 8, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
- Updates opportunity score function to forward `browser.name` query filter to secondary helper query
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browser.namequery filter to secondary helper queryrevised #82967
The previous pr was forwarding all query filters including those of type
AggregateFilter, which causes the query to have a "having" clause which is unsupported. Updates to only forwardbrowser.nameto support the browser filter in the webvitals module ui.