chore(snetry apps): Make SentryAppSentryErrors for Sentry side errors #83080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83080 +/- ##
==========================================
- Coverage 87.59% 87.58% -0.01%
==========================================
Files 9423 9428 +5
Lines 536407 536529 +122
Branches 21120 21120
==========================================
+ Hits 469839 469911 +72
- Misses 66209 66259 +50
Partials 359 359 |
Christinarlong
commented
Jan 8, 2025
Comment on lines
-48
to
-63
| try: | ||
| external_issue = ExternalIssueCreator( | ||
| install=installation, | ||
| group=group, | ||
| web_url=data["webUrl"], | ||
| project=data["project"], | ||
| identifier=data["identifier"], | ||
| ).run() | ||
| except Exception as e: | ||
| error_id = capture_exception(e) | ||
| return Response( | ||
| { | ||
| "error": f"An issue occured while trying to create external issue. Sentry error ID: {error_id}" | ||
| }, | ||
| status=500, | ||
| ) |
There was a problem hiding this comment.
Previously we had an exception catcher in the endpoint and because we determined any errors happening from this block would be our fault we responded here. Now we can use the top level error handler to do that and let the exception go up.
sentaur-athena
approved these changes
Jan 8, 2025
| error_id = sentry_sdk.capture_exception(exception) | ||
| return Response( | ||
| { | ||
| "error": f"An issue occured during the Sentry App process. Sentry error ID: {error_id}" |
There was a problem hiding this comment.
nit: customers don't know what a sentry app is, that's our internal term. Want to use something like "integration"?
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl:dr This PR adds a new error type for Sentry side errors that shouldnt be sent to the integrator but still should be handled gracefully. So we can distinguish between truly Unhandled exceptions, and exceptions we have audited and thought about.
Context: Currently with only
SentryAppErrors(client side errors) &SentryAppIntegratorErrors(integrator side errors) if we have a non wrapped error (i.e our fault error) then it will go through the default django rest_framework exception handler. This is okay for certain errors like authentication (i.e children ofAPIException) which rest_framework handles gracefully. However, if the exception does not inherit fromAPIException, they will be considered 'Unhandled' in Sentry.