feat(workflow_engine): Add the ErrorDetectorValidator to the Error Issue Group #83083
+48
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
…import clause to fix circular import
saponifi3d
force-pushed
the
jcallender/aci/error-detector-validator
branch
from
fc8973c to
2e2deda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#82578 but re-imagined a little. Rather than pulling apart the
grouptypefile to fix the circular imports, this adds anif TYPE_CHECKINGto stop the cycle and begins to break apart the validators instead. (We might want to pull out the condition validators, possibly the detector)