fix(org-stats): Require project membership #83085
Merged
+77
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
obostjancic
approved these changes
Jan 8, 2025
ArthurKnaus
deleted the
aknaus/fix/org-stats/require-project-membership
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the user is not member of any project (closes team membership) the organization stats page can end up in two different states.
Both states are not ideal.
State 1 suggests on a first glance that there is no traffic in this organization and does not provide any valuable information.
But state 2 is problematic as requests fail and the page looks broken.
Solution
Wrap the page in
<NoProjectMessage />as we do for other pages that rely on project data.Close #82998