feat(onboarding): Generic copy DSN #83088
Merged
+106
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
shellmayr
changed the title
shellmayr
reviewed
Jan 8, 2025
| @@ -111,6 +112,9 @@ const onboarding: OnboardingConfig = { | |||
| </List> | |||
| ), | |||
| }, | |||
| { | |||
| description: <CopyDnsField params={params} />, | |||
There was a problem hiding this comment.
This is supposed to be CopyDsnField, right?
There was a problem hiding this comment.
haha, classic 🙈 thx for pointing out!
shellmayr
reviewed
Jan 8, 2025
| </p> | ||
| <TextCopyInput | ||
| onCopy={() => | ||
| trackAnalytics('onboarding.nextjs-dsn-copied', { |
There was a problem hiding this comment.
Is this always supposed to be this analytics string - I suppose when used in e.g. SvelteKit, we don't want to track this as nextjs-dsn-copied, right?
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Move the "copy DSN" section into manual configuration. Add it to every platform doc that instructs to use the wizard. Closes #80179
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the "copy DSN" section into manual configuration.
Add it to every platform doc that instructs to use the wizard.
Closes #80179