feat(ui): Wrap react select to remove defaultprops #83617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes default props for react 19 compatibility. React select itself has so many default props it seems important to re-apply those.
github-actions
bot
added
the
Scope: Frontend
TkDodo
reviewed
Jan 17, 2025
| mergeStyles, | ||
| ReactSelect, | ||
| selectComponents, | ||
| } from 'sentry/components/forms/controls/reactSelectWrapper'; |
There was a problem hiding this comment.
the wrapper is good trick 👍 . Maybe we should accommodate it with an update to the restrictedImportPaths in our eslint config to avoid accidental direct imports of react-select:
Line 45 in 48f06ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes default props for react 19 compatibility. React select itself has so many default props it seems important to re-apply those.
part of https://github.com/getsentry/frontend-tsc/issues/68