Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metric-issues): Add lastChecked to OpenPeriod #83970

Merged
merged 1 commit into from
Jan 23, 2025
Merged

feat(metric-issues): Add lastChecked to OpenPeriod #83970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions static/app/types/group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,7 @@ export interface GroupOpenPeriod {
end: string;
isOpen: boolean;
start: string;
lastChecked?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be optional? if not, maybe string | null would be a better match for the backend type

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating the backend PR - it shouldn't ever be null in theory. I'm marking it optional for now while we add the field and will change to required after the PRs land.

}

export interface GroupReprocessing extends BaseGroup, GroupStats {
Expand Down
Loading