Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(uptime): Backend support for active / disable #83971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(uptime): Backend support for active / disable #83971

wants to merge 1 commit into from
+175 −2

Conversation

evanpurkhiser
Copy link
Member

Allows uptime rules (monitors) to be marked as disabled / active via the
details endpoint

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner January 23, 2025 23:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
23640 1 23639 289
View the top 1 failed tests by shortest run time 
tests.sentry.uptime.endpoints.test_project_uptime_alert_details.ProjectUptimeAlertDetailsPutEndpointTest::test_status_enable
Stack Traces | 0.246s run time 
#x1B[1m#x1B[.../uptime/endpoints/test_project_uptime_alert_details.py#x1B[0m:215: in test_status_enable
    uptime_monitor = self.create_project_uptime_subscription(status=ObjectStatus.DISABLED)
#x1B[1m#x1B[31mE   TypeError: Fixtures.create_project_uptime_subscription() got an unexpected keyword argument 'status'#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@evanpurkhiser