feat(releases): add error free session rate chart to frontend insights #84834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
commented
Feb 8, 2025
Comment on lines
28
to
61
| const { | ||
| data: sessionsData, | ||
| isPending, | ||
| error, | ||
| } = useApiQuery<SessionApiResponse>( | ||
| [ | ||
| `/organizations/${organization.slug}/sessions/`, | ||
| {query: {...location.query, field: ['sum(session)'], groupBy: ['session.status']}}, | ||
| ], | ||
| {staleTime: 0} | ||
| ); | ||
|
|
||
| if (!sessionsData) { | ||
| return null; | ||
| } | ||
|
|
||
| // Get the healthy sessions series data | ||
| const healthySessionsSeries = | ||
| sessionsData.groups.find(group => group.by['session.status'] === 'healthy')?.series[ | ||
| 'sum(session)' | ||
| ] ?? []; | ||
|
|
||
| // Calculate total sessions for each interval | ||
| const totalSessionsByInterval = sessionsData.groups[0]?.series['sum(session)']?.map( | ||
| (_, intervalIndex) => | ||
| sessionsData.groups.reduce( | ||
| (acc, group) => acc + (group.series['sum(session)']?.[intervalIndex] ?? 0), | ||
| 0 | ||
| ) | ||
| ); | ||
|
|
||
| // Calculate percentage for each interval | ||
| const healthySessionsPercentageData = healthySessionsSeries.map( | ||
| (healthyCount, index) => { |
There was a problem hiding this comment.
i should probably move all this calculation stuff into a separate hook
michellewzhang
commented
Feb 8, 2025
Comment on lines
+82
to
+101
| <InsightsLineChartWidget | ||
| title={t('Error Free Session Rate')} | ||
| series={[ | ||
| { | ||
| data: healthySessionsPercentageData.map((val, idx) => { | ||
| return {name: sessionsData.intervals[idx] ?? '', value: val}; | ||
| }), | ||
| seriesName: 'Error free session rate', | ||
| meta: { | ||
| fields: { | ||
| 'Error free session rate': 'percentage', | ||
| time: 'date', | ||
| }, | ||
| units: { | ||
| 'Error free session rate': '%', | ||
| }, | ||
| }, | ||
| }, | ||
| ]} | ||
| isLoading={isPending} | ||
| error={error} | ||
| /> |
There was a problem hiding this comment.
this could also be a separate component
michellewzhang
force-pushed
the
mz/add-error-free-chart
branch
from
a798306 to
09c1f7e
Compare
Bundle ReportChanges will increase total bundle size by 47.57kB (0.14%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
|
michellewzhang
commented
Feb 8, 2025
| data: healthySessionsPercentageData.map((val, idx) => { | ||
| return {name: sessionsData.intervals[idx] ?? '', value: val}; | ||
| }), | ||
| seriesName: 'Error free session rate', |
There was a problem hiding this comment.
the name "error free session rate" is super vague, maybe we need a question tooltip or something to clarify what this means?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-02-07.at.5.05.21.PM.mov
the full screen behavior after clicking on the legend is a bit janky but is consistent w/ other widgets in insights
relates to https://github.com/getsentry/team-replay/issues/540