feat(eap-rpc): Add an uptime check resolver #6805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuba/datasets/configuration/events_analytics_platform/entities/uptime_checks.yaml
Outdated
Show resolved
Hide resolved
volokluev
reviewed
Jan 22, 2025
snuba/datasets/configuration/events_analytics_platform/entities/uptime_checks.yaml
Outdated
Show resolved
Hide resolved
| ) | ||
|
|
||
|
|
||
| def _convert_result_timeseries( |
There was a problem hiding this comment.
I think this function we could definitely move to the higher level common module
Comment on lines
+181
to
+207
| # buckets time by granularity according to the start time of the request. | ||
| # time_slot = start_time + (((timestamp - start_time) // granularity) * granularity) | ||
| # Example: | ||
| # start_time = 1001 | ||
| # end_time = 1901 | ||
| # granularity = 300 | ||
| # timestamps = [1201, 1002, 1302, 1400, 1700] | ||
| # buckets = [1001, 1301, 1601] # end time not included because it would be filtered out by the request | ||
| SelectedExpression( | ||
| name="time", | ||
| expression=f.toDateTime( | ||
| f.plus( | ||
| request.meta.start_timestamp.seconds, | ||
| f.multiply( | ||
| f.intDiv( | ||
| f.minus( | ||
| f.toUnixTimestamp(column("timestamp")), | ||
| request.meta.start_timestamp.seconds, | ||
| ), | ||
| request.granularity_secs, | ||
| ), | ||
| request.granularity_secs, | ||
| ), | ||
| ), | ||
| alias="time_slot", | ||
| ), | ||
| ), |
There was a problem hiding this comment.
because you have this you don't need the time series processor
There was a problem hiding this comment.
also a good candidate for a common module
snuba/web/rpc/v1/resolvers/R_uptime_checks/resolver_trace_item_table.py
Outdated
Show resolved
Hide resolved
snuba/web/rpc/v1/resolvers/R_uptime_checks/resolver_trace_item_table.py
Outdated
Show resolved
Hide resolved
|
|
||
| @pytest.mark.clickhouse_db | ||
| @pytest.mark.redis_db | ||
| class TestTraceItemTable(BaseApiTest): |
There was a problem hiding this comment.
write a timeseries test as well?
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a resolver to support the uptime check item type.