Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add EndpointTraceItemStats RPC #6809

Merged
merged 18 commits into from
Feb 3, 2025

Conversation

shruthilayaj
Copy link
Member

@shruthilayaj shruthilayaj commented Jan 23, 2025

requires getsentry/sentry-protos#101, will bump package once it's merged

For comparison workflows, we need the count distribution data of all attribute/value pairs (both string and numeric, however we'll focus on string first). We're introducing a trace item stats endpoint to facilitate that. The aim is to build a somewhat generic endpoint that can give a high level overview of the shape of your data.

This implementation is fairly simple, restricted to string attributes to begin with. It returns the frequency distribution of attributes in the requested filter. The data returned is ordered by keys that have the highest frequency attribute values.

This first pass aims to also unblock work the ML team is doing to finalize the algorithm to rank these attributes.

@shruthilayaj shruthilayaj changed the title wip: Add EndpointTraceItemStats RPC feat: Add EndpointTraceItemStats RPC Jan 29, 2025
@shruthilayaj shruthilayaj marked this pull request as ready for review January 29, 2025 15:24
@shruthilayaj shruthilayaj requested review from a team as code owners January 29, 2025 15:24
@shruthilayaj shruthilayaj requested a review from phacops January 29, 2025 15:25
Copy link
Contributor

@phacops phacops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up comments that are not useful anymore, the duplicated constants in the endpoint and the resolvers.

@shruthilayaj shruthilayaj merged commit 32fd1c7 into master Feb 3, 2025
31 checks passed
@shruthilayaj shruthilayaj deleted the shruthi/feat/add-EndpointTraceItemStats-RPC branch February 3, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants