Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repository URL from mozilla/sops to getsops/sops #1254

Closed
wants to merge 1 commit into from
Closed

Update repository URL from mozilla/sops to getsops/sops #1254

wants to merge 1 commit into from

Conversation

tuxiqae
Copy link

@tuxiqae tuxiqae commented Aug 2, 2023

No description provided.

devstein
devstein reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tuxiqae thanks for making a PR to fix this! There is already an open PR for this renaming migration, #1247 , so I'm going to close this.

@devstein devstein closed this Aug 2, 2023
@tuxiqae
Copy link
Author

tuxiqae commented Aug 2, 2023 •
edited
Loading

@devstein The PR in question does not take care of the same issue.
PR #1247 renames the module name, PR #1254 (this one) renames the name of the repo itself.
It might be smarter to add my commit to PR #1247, but that's up to you, I do not think that those two things should depend on one another.

@devstein
Copy link
Contributor

devstein commented Aug 2, 2023

@tuxiqae Thank you for clarifying 😅

@devstein devstein reopened this Aug 2, 2023
@felixfontein
Copy link
Contributor

Isn't this already covered by #1244?

@devstein devstein closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devstein devstein devstein left review comments

@hiddeco hiddeco Awaiting requested review from hiddeco

@onedr0p onedr0p Awaiting requested review from onedr0p

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuxiqae @devstein @felixfontein