Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stores/ini] Relax ini parser #752

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2020

Specifically: Allow hash/semicolon in values and Python multi-line indented values - refs #751

@codecov-commenter
Copy link

Codecov Report

Merging #752 into develop will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #752      +/-   ##
===========================================
+ Coverage    33.35%   33.64%   +0.29%     
===========================================
  Files           23       23              
  Lines         3076     3082       +6     
===========================================
+ Hits          1026     1037      +11     
+ Misses        1917     1913       -4     
+ Partials       133      132       -1     
Impacted Files Coverage Δ
pgp/keysource.go 30.25% <100.00%> (ø)
stores/ini/store.go 29.89% <100.00%> (+2.36%) ⬆️
stores/flatten.go 90.29% <0.00%> (+4.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acbe73...0b84e28. Read the comment docs.

@felixfontein
Copy link
Contributor

Looking at this in the context of #1597, I think this is a breaking change. Adding it to #1435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants