-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llama : refactor llama_context, llama_kv_cache, llm_build_context (v2) #12181
Open
ggerganov
wants to merge
13
commits into
master
Choose a base branch
from
gg/llama-kv-cache-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13,655
−11,940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
766edbf
to
62ba774
Compare
Planning to merge this tomorrow unless there are any suggestions for improvements. |
slaren
approved these changes
Mar 11, 2025
ggml-ci
ggml-ci
62ba774
to
a170669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alt #11213
Overview
The implementation in #11213 became too complicated, trying to make a lot of changes at once. This is an alternative implementation, which does not involve the abstraction of the
llama_context
. The PR introduces some new abstractions, improves the graph build handling and is an initial step for the next changes listed in section "Next" below.llm_build_context
into newllm_graph_context
implemented inllama-graph.h/.cpp
llm_graph_input_...
classes for handling graph inputs in a safer and cleaner wayllm_graph_result
for extracting important tensors such as embeddings and logits, instead of searching for them by tensor namellm_memory_i
concept that will abstract different cache/memory mechanisms. For now we have onlyllama_kv_cache
as a type of memoryllama_io_write_i
andllama_io_read_i
interfacesAPI changes
The current changes are only necessary to make the API more consistent in following the naming convention. To migrate, simply replace the old API calls with the new ones.
llama_kv_cache_...
APIllama_kv_self_...
APINext
class llama_kv_cache_recurrent
and remove all recurrent logic from the existingclass llama_kv_cache_unified
. Simplifyllama_kv_cache_unified
.