Skip to content

backport CoreML features to macos < 14 #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Conversation

glaszig
Copy link
Contributor

@glaszig glaszig commented Jun 16, 2025

i'm on 12.7 and [MLModel predictionFromFeatures:] versions with completion handler are only available on macos 14 which is a little too cutting edge for me.

before this i'd get:

whisper-encoder-impl.m:183:17: error: no visible @interface for 'MLModel'
declares the selector 'predictionFromFeatures:completionHandler:'
    [self.model predictionFromFeatures:input completionHandler:^(id<MLFeatureProvider> prediction, NSError *predictionError) {
     ~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@glaszig
Copy link
Contributor Author

glaszig commented Jun 20, 2025

done.

@glaszig
Copy link
Contributor Author

glaszig commented Jun 24, 2025

done. also squashed commits.

@glaszig
Copy link
Contributor Author

glaszig commented Jun 24, 2025

oops. fixed.

@danbev danbev merged commit 0083335 into ggml-org:master Jun 24, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants