Compatibility with ggplot2 3.5.0 #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just a quick little update to let you know that we've picked the 12th of February as release date. |
|
And this is a kind reminder that the release is scheduled soon. |
|
@teunbrand Thank you for the wonderful PR and reminders! |
schloerke
reviewed
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: This PR aims to fix #481.
We have been preparing a new release of ggplot2, and during a reverse dependency check, it became apparent that the prospective ggplot 3.5.0 would break GGally.
Given GGally's important role in the R ecosystem, we felt it was prudent to help out to transition to the new version.
The culprit is that ggplot2 changed the way legends are placed in the gtable, see tidyverse/ggplot2#5488.
This PR handles the new legend structure, and should work with both the current and the development version of ggplot2.
To test the code changes with the release candidate, you can install it with the code below:
The release of ggplot2 3.5.0 is scheduled at the end of January / early Februari. The progress can be tracked in tidyverse/ggplot2#5588.
We are hoping that this PR might help GGally be ready around that time to soften the impact on downstream packages.