Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work package creation (GSI-1302) #53

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

Cito
Copy link
Member

@Cito Cito commented Feb 1, 2025

This PR adds a form that gathers the information needed to create a work package. This also includes validation of the public key.

This PR does not include validation of file accessions since this was not done in the legacy app. I have put this on the refactoring list.

Actual work package and showing the created token will be implemented as a separate task, this is pretty easy now.

@Cito Cito self-assigned this Feb 1, 2025
Copy link
Member

@SilverLinings89 SilverLinings89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments, none need work now.

src/app/auth/services/auth.service.ts Show resolved Hide resolved
src/mocks/responses.ts Show resolved Hide resolved
@Cito Cito removed the request for review from ac-jorellanaf February 3, 2025 13:06
@Cito Cito merged commit 9f54b36 into main Feb 3, 2025
3 checks passed
@Cito Cito deleted the feature/add-work-package-creation-1302 branch February 3, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants