Feature/basal account page gsi 1296 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2025 14:55
Cito
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
This page would look a bit less boring with some contrasting colors and icons.
E.g. the heading could have a larger "user profile" icon and the individual sections smaller icons on the top left corner.
We can also experiment with giving the card headers an orange background with white text or something like that.
But we can also do this in an additional "polish account page" task.
Cito
previously approved these changes
Feb 3, 2025
@Cito's suggestions. Co-authored-by: Christoph Zwerschke <[email protected]> Signed-off-by: Pascal Kraft <[email protected]>
Cito
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue 1296. Layout different than in old ui. May need some work still.