Logger support, rewrote most of it to support unit testing better

[inditel]

Added Zend Logger support. Now all errors can also be logged through Zend Logger.

Pull is optional, if you think it should not be done, I will continue with the fork.

(If merged, check readme.md and composer.json for package names. They should be changed.)

[ghislainf]

Hi,
I saw that quickly and it looks great ! I will take a look in detail on monday for the merge.
Thanks !

[ghislainf]

The logs files are illegible, an exemple :

2013-06-24T22:41:48+02:00 ERR (3):  {"file":"\/Volumes\/Project\/Sites\/zf2app\/module\/Application\/src\/Application\/Controller\/IndexController.php","line":20,"trace":"[\"{\\\"file\\\":\\\"\\\\\\\/Volumes\\\\\\\/Project\\\\\\\/Sites\\\\\\\/zf2app\\\\\\\/vendor\\\\\\\/zendframework\\\\\\\/zendframework\\\\\\\/library\\\\\\\/Zend\\\\\\\/Mvc\\\\\\\/Controller\\\\\\\/AbstractActionController.php\\\",\\\"line\\\":83,\\\"function\\\":\\\"indexAction\\\",\\\"class\\\":\\\"Application\\\\\\\\Controller\\\\\\\\IndexController\\\",\\\"type\\\":\\\"->\\\",\\\"args\\\":\\\"[]\\\"}\",\"{\\\"function\\\":\\\"onDispatch\\\",\\\"class\\\":\\\"Zend\\\\\\\\Mvc\\\\\\\\Controller\\\\\\\\AbstractActionController\\\",\\\"type\\\":\\\"->\\\",\\\"args\\\":\\\"[\\\\\\\"object(Zend\\\\\\\\\\\\\\\\Mvc\\\\\\\\\\\\\\\\MvcEvent) {}\\\\\\\"]\\\"}\",\"{\\\"file\\\":\\\"\\\\\\\/Volumes\\\\\\\/Project\\\\\\\/Sites\\\\\\\/zf2app\\\\\\\/vendor\\\\\\\/zendframework\\\\\\\/zendframework\\\\\\\/library\\\\\\\/Zend\\\\\\\/EventManager\\\\\\\/EventManager.php\\\",\\\"line\\\":472,\\\"function\\\":\\\"call_user_func\\\",\\\"args\\\":\\\"[\\\\\\\"[\\\\\\\\\\\\\\\"object(Application\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\Controller\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\IndexController) {}\\\\\\\\\\\\\\\",\\\\\\\\\\\\\\\"onDispatch\\\\\\\\\\\\\\\"]\\\\\\\",\\\\\\\"object(Zend\\\\\\\\\\\\\\\\Mvc\\\\\\\\\\\\\\\\MvcEvent) {}\\\\\\\"]\\\"}\",\"{\\\"file\\\":\\\"\\\\\\\/Volumes\\\\\\\/Project\\\\\\\/Sites\\\\\\\/zf2app\\\\\\\/vendor\\\\\\\/zendframework\\\\\\\/zendframework\\\\\\\/library\\\\\\\/Zend\\\\\\\/EventManager\\\\\\\/EventManager.php\\\",\\\"line\\\":207,\\\"function\\\":\\\"triggerListeners\\\",\\\"class\\\":\\\"Zend\\\\\\\\EventManager\\\\\\\\EventManager\\\",\\\"type\\\":\\\"->\\\",\\\"args\\\":\\\"[\\\\\\\"dispatch\\\\\\\",\\\\\\\"object(Zend\\\\\\\\\\\\\\\\Mvc\\\\\\\\\\\\\\\\MvcEvent) {}\\\\\\\",\\\\\\\"object(Closure) {}\\\\\\\"]\\\"}\",\"{\\\"file\\\":\\\"\\\\\\\/Volumes\\\\\\\/Project\\\\\\\/Sites\\\\\\\/zf2app\\\\\\\/vendor\\\\\\\/zendframework\\\\\\\/zendframework\\\\\\\/library\\\\\\\/Zend\\\\\\\/Mvc\\\\\\\/Controller\\\\\\\/AbstractController.php\\\",\\\"line\\\":117,\\\"function\\\":\\\"trigger\\\",\\\"class\\\":\\\"Zend\\\\\\\\EventManager\\\\\\\\EventManager\\\",\\\"type\\\":\\\"->\\\",\\\"args\\\":\\\"[\\\\\\\"dispatch\\\\\\\",\\\\\\\"object(Zend\\\\\\\\\\\\\\\\Mvc\\\\\\\\\\\\\\\\MvcEvent) {}\\\\\\\",\\\\\\\"object(Closure) {}...

This part must be reviewed.
Cheers ! 🍺

[inditel]

Hi

This is done by zend logger. It should be the same if logger logs this
information without whoops part or without my code.

Oliver

On Mon, Jun 24, 2013 at 11:55 PM, ghislainf [email protected]:

The logs files are illegible, an exemple :

2013-06-24T22:41:48+02:00 ERR (3): {"file":"/Volumes/Project/Sites/zf2app/module/Application/src/Application/Controller/IndexController.php","line":20,"trace":"["{\"file\":\"\\/Volumes\\/Project\\/Sites\\/zf2app\\/vendor\\/zendframework\\/zendframework\\/library\\/Zend\\/Mvc\\/Controller\\/AbstractActionController.php\",\"line\":83,\"function\":\"indexAction\",\"class\":\"Application\\Controller\\IndexController\",\"type\":\"->\",\"args\":\"[]\"}","{\"function\":\"onDispatch\",\"class\":\"Zend\\Mvc\\Controller\\AbstractActionController\",\"type\":\"->\",\"args\":\"[\\"object(Zend\\\\Mvc\\\\MvcEvent) {}\\"]\"}","{\"file\":\"\\/Volumes\\/Project\\/Sites\\/zf2app\\/vendor\\/zendframework\\/zendframework\\
/library\\/Zend\\/EventManager\\/EventManager.php\",\"line\":472,\"function\":\"call_user_func\",\"args\":\"[\\"[\\\\"object(Application\\\\\\\\Controller\\\\\\\\IndexController) {}\\\\",\\\\"onDispatch\\\\"]\\",\\"object(Zend\\\\Mvc\\\\MvcEvent) {}\\"]\"}","{\"file\":\"\\/Volumes\\/Project\\/Sites\\/zf2app\\/vendor\\/zendframework\\/zendframework\\/library\\/Zend\\/EventManager\\/EventManager.php\",\"line\":207,\"function\":\"triggerListeners\",\"class\":\"Zend\\EventManager\\EventManager\",\"type\":\"->\",\"args\":\"[\\"dispatch\\",\\"object(Zend\\\\Mvc\\\\MvcEvent) {}\\",\\"object(Closure) {}\\"]\"}","{\"file\":\"\\/Volume
s\\/Project\\/Sites\\/zf2app\\/vendor\\/zendframework\\/zendframework\\/library\\/Zend\\/Mvc\\/Controller\\/AbstractController.php\",\"line\":117,\"function\":\"trigger\",\"class\":\"Zend\\EventManager\\EventManager\",\"type\":\"->\",\"args\":\"[\\"dispatch\\",\\"object(Zend\\\\Mvc\\\\MvcEvent) {}\\",\\"object(Closure) {}...

This part must be reviewed.
Cheers ! [image: 🍺]

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-19935161
.

Lugupidamisega,
Oliver Leisalu