fix: Use full hostname & unify pause logic #2171
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2168 and unifies pause behavior on subdomains if the top domain is paused.
onCommited
instead ofonBeforeNavigate
to properly trigger setup after initial 30X redirects - thecnn.com
oronet.pl
sites are good examples - theonCommited
is triggered once, but after redirects, with the final URLwww.
subdomain was mainly caused by the above bug to avoid situations where not the latest (and correct) hostname was added to paused websiteswww
subdomain, we can only hide it in the panel header, as the browsers hide it in the URL address barexmaple.com
works also forabc.exmaple.com
- because of that this PR also unifies the behavior of theisPaused()
function andisTrusted()
for exceptions in Firefox - for the consistent logic through all the platforms. Unification helps with no-stress migration from the current production logic - if a user addedonet.pl
, it will work with unified logic as well, as thewww.onet.pl
contains theonet.pl
(for isPaused and exceptions).