Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use full hostname & unify pause logic #2171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

smalluban
Copy link
Collaborator

@smalluban smalluban commented Dec 31, 2024

Fixes #2168 and unifies pause behavior on subdomains if the top domain is paused.

  • The tab stats setup should be done in onCommited instead of onBeforeNavigate to properly trigger setup after initial 30X redirects - the cnn.com or onet.pl sites are good examples - the onCommited is triggered once, but after redirects, with the final URL
  • The removal of the www. subdomain was mainly caused by the above bug to avoid situations where not the latest (and correct) hostname was added to paused websites
  • Instead of removing the www subdomain, we can only hide it in the panel header, as the browsers hide it in the URL address bar
  • The DNR allow rule for exmaple.com works also for abc.exmaple.com - because of that this PR also unifies the behavior of the isPaused() function and isTrusted() for exceptions in Firefox - for the consistent logic through all the platforms. Unification helps with no-stress migration from the current production logic - if a user added onet.pl, it will work with unified logic as well, as the www.onet.pl contains the onet.pl (for isPaused and exceptions).

@smalluban smalluban added the package CI: create extension packages label Dec 31, 2024
@smalluban smalluban requested a review from chrmod December 31, 2024 13:54
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package CI: create extension packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghostery is not paused
1 participant