Travis updates: Alpine builds and codecov reports #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
gicmo
commented
Sep 3, 2019
gicmo
commented
- Include Alpine in the build matrix.
- Send coverage results to codecov.io
This is actually required for Alpine container builds because musl libc, used by Alpine, does not have a compat implementation of copy_file_range (introduce in Linux 4.5) and the kernel used by trusty is < 4.5 and thus bolt_copy_bytes will fail, because copy_file_range will fail.
The Dockerfile for testing on alpine (which uses the musl libc) is already present and used on Gitlab CI, so lets also use it on travis.
Instead of provisioning the /build dir in the build script, do it while building the container.
Create an OS specific build path (build-$OS) outside the container and mount it to /build within the container. This allows us to capture artifacts (build logs, coverage reports) and used them from outside the container.
After a successful build, submit the coverage to codecov.io. The information is provided by the fedora container build.
gicmo
force-pushed
the
travis_updates
branch
from
3fd9070
to
f028ab0
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
===========================================
- Coverage 88.98% 63.44% -25.55%
===========================================
Files 83 83
Lines 13059 13060 +1
Branches 4022 3944 -78
===========================================
- Hits 11621 8286 -3335
- Misses 1438 1696 +258
- Partials 0 3078 +3078
Continue to review full report at Codecov.
|
Fedora 30 is the current stable (since quite a while). The bolt package wont be updated in < 30, so test with the latest stable.
Create artifacts from the build logs for all containers.
gicmo
force-pushed
the
travis_updates
branch
from
34b0e8b
to
d7941c7
Compare
Running it outside seems to lead to wrong results. Try inside.
gicmo
force-pushed
the
travis_updates
branch
from
d7941c7
to
81d3e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.