-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[view] Remote Git config에서 owner, repo 정보를 View에서 받는 방식 수정 #768
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c12c493
refactor(view): EventListner를 추가하여 owner, repo 정보를 할당하는 부분 삭제
seungineer 9dbdb2f
feat(view): owner, repo 정보를 담는 githubInfo store 생성
seungineer 7ee620b
feat(view): githubInfo 조작 함수 추가
seungineer 596d5a1
refactor(vscode): vscode에서 owner, repo를 위한 postMessage 삭제
seungineer 19beb07
feat(vscode): Github Info를 fetch하는 기능
seungineer 79bbf99
feat(view): view에서 Github Info를 fetch하도록 명령하는 기능
seungineer bcf0931
feat(view): dev mode에서도 Github Info를 fetch하도록 기능 추가
seungineer d90d0d8
refactor(view): 불필요한 owner, repo store 삭제
seungineer 961be97
fix(view): 기존 owner, repo store를 사용하던 것을 githubInfo store 사용으로 수정
seungineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 2 additions & 3 deletions
5
packages/view/src/components/VerticalClusterList/Summary/Content/Content.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { create } from "zustand"; | ||
|
||
export type githubInfo = { | ||
owner: string; | ||
repo: string; | ||
}; | ||
|
||
export const useGithubInfo = create< | ||
githubInfo & { | ||
handleGithubInfo: (repoInfo: githubInfo) => void; | ||
} | ||
>((set) => ({ | ||
owner: "githru", | ||
repo: "githru-vscode-ext", | ||
handleGithubInfo: (repoInfo: githubInfo) => { | ||
if (repoInfo) { | ||
set({ owner: repoInfo.owner, repo: repoInfo.repo }); | ||
} | ||
}, | ||
})); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
export * from "./loading"; | ||
export * from "./filteredRange"; | ||
export * from "./branch"; | ||
export * from "./repo"; | ||
export * from "./owner"; | ||
export * from "./githubInfo"; | ||
export * from "./data"; |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
import type { BranchListPayload } from "store"; | ||
import type { BranchListPayload, githubInfo } from "store"; | ||
import type { ClusterNode } from "types"; | ||
|
||
// triggered by ide response | ||
export type IDESentEvents = { | ||
handleChangeAnalyzedData: (analyzedData: ClusterNode[]) => void; | ||
handleChangeBranchList: (branches: BranchListPayload) => void; | ||
handleGithubInfo: (repoInfo: githubInfo) => void; | ||
}; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍